Add exchange_rate to operation
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnovitskyi
commented
Nov 9, 2023
vnovitskyi
requested review from
frantisekrokusek,
jlebray and
NathanBerthier
as code owners
lib/cfonb/operation_detail/mmo.rb
Outdated
| @@ -14,6 +14,7 @@ def self.apply(operation, line) | |||
| sign = operation.amount <=> 0 # the detail amount is unsigned | |||
|
|
|||
| operation.original_amount = sign * BigDecimal(line.detail[4..17]) / (10**scale) | |||
| operation.exchange_rate = BigDecimal(line.detail[-4..-1]) / 1000 | |||
There was a problem hiding this comment.
For reference the official definition does not state it will always be the exchange rate
lib/cfonb/operation_detail/mmo.rb
Outdated
| @@ -14,6 +14,7 @@ def self.apply(operation, line) | |||
| sign = operation.amount <=> 0 # the detail amount is unsigned | |||
|
|
|||
| operation.original_amount = sign * BigDecimal(line.detail[4..17]) / (10**scale) | |||
| operation.exchange_rate = BigDecimal(line.detail[-4..-1]) / 1000 | |||
There was a problem hiding this comment.
Suggested change
| operation.exchange_rate = BigDecimal(line.detail[-4..-1]) / 1000 | |
| operation.exchange_rate = BigDecimal(line.detail[18..52]) / 1000 |
There was a problem hiding this comment.
why 18..52?
not 26..29?
There was a problem hiding this comment.
My mistake is should have been this 18..69
You are taking the assumption from 1 single example but the documentation states the last section size is 52 starting position 67-49 = 18
lib/cfonb/operation_detail/mmo.rb
Outdated
Comment on lines
17
to
18
| exchange_rate_value = line.detail[26..29] | ||
| operation.exchange_rate = BigDecimal(exchange_rate_value) / 1000 if exchange_rate_value |
There was a problem hiding this comment.
we are missing the scale of the exchange rate also
Suggested change
| exchange_rate_value = line.detail[26..29] | |
| operation.exchange_rate = BigDecimal(exchange_rate_value) / 1000 if exchange_rate_value | |
| exchange_rate_value = line.detail[26..29] | |
| exchange_rate_scale = line.detail[18] | |
| operation.exchange_rate = BigDecimal(exchange_rate_value) / (10**exchange_rate_scale) if exchange_rate_value |
There was a problem hiding this comment.
@frantisekrokusek make sense. thank
code is updated
| @@ -14,6 +14,11 @@ def self.apply(operation, line) | |||
| sign = operation.amount <=> 0 # the detail amount is unsigned | |||
|
|
|||
| operation.original_amount = sign * BigDecimal(line.detail[4..17]) / (10**scale) | |||
| exchange_rate_value = line.detail[26..29] | |||
There was a problem hiding this comment.
this can still be wrong but ok to keep it like that for now
frantisekrokusek
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Sobank statements include exchange rate. We need to parse the value and apply to a transaction.